-
Notifications
You must be signed in to change notification settings - Fork 53
fix: update Markdown cheatsheet links in issue templates 1, 3, and 4 #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: update Markdown cheatsheet links in issue templates 1, 3, and 4 #130
Conversation
SanJSp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @menschenkind !
Thank you for your contribution. I added a comment regarding a different link, please use this one (is in German + does not automatically download). Would mind taking a look at the english repo as well?
Thank you!
| #### Dateien | ||
| Wenn du nicht weißt, wie man einen Titel erstellt, schau mal auf dieses Cheatsheet unter Header. Du sollst einen H1 Header verwenden. Bedenke, dass Markdown Symbole häufig von einem Leerzeichen gefolgt werden, um korrekt zu rendern. | ||
| https://guides.github.com/pdfs/markdown-cheatsheet-online.pdf | ||
| https://enterprise.github.com/downloads/en/markdown-cheatsheet.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using this resource instead? You could also change this in the english repo .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the idea of that link initially seemed reasonable to me as well. However, your task states: 'You should use an H1 header.' The PDF explains how to implement this, whereas the other link doesn’t mention H1 at all.
Furthermore, your linked page is not fully localized. While the heading and the opening section are in German, the rest of the content remains in English.
I will check / change the english repo as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very valid points! Agreed!
SanJSp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
|
Thanks for approving this pull request. Will you merge it soon, or should I do anything else? |
Summary
This PR updates the outdated Markdown cheatsheet PDF links in issue templates 1, 3, and 4.
Changes
https://enterprise.github.com/downloads/en/markdown-cheatsheet.pdf
Motivation
The previous link pointed to an outdated resource. Updating ensures contributors have access to the correct Markdown reference.
Related Issue
Fixes #129