Skip to content

Fix JuliaFormatter line splits across DelayDiffEq.jl #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

ChrisRackauckas
Copy link
Member

Summary

  • Fix 8 unnecessary line splits across 6 files in DelayDiffEq.jl
  • Combine arithmetic expressions, function calls, and test assertions for better readability
  • Keep semantically related code units together while staying under 120-character limits

Changes

  • src/integrators/interface.jl: Combined split multiplication integrator.tdir * integrator.t
  • src/fpsolve/utils.jl: Combined split constructor calls for FPAndersonCache and FPSolver
  • test/interface/*.jl: Combined split test assertions across multiple test files

Background

This follows the formatting guidelines established in Catalyst.jl PR #1306 to improve code readability by avoiding unnecessary line splits. The current JuliaFormatter has issues with overly aggressive line breaking (see JuliaFormatter.jl PR #934 for the upstream fix).

Test plan

  • All changes maintain identical functionality
  • Line lengths stay under 120 characters
  • Semantically related expressions are kept together

🤖 Generated with Claude Code

- Combine split arithmetic expressions (integrator.tdir * integrator.t)
- Combine split function constructor calls in fpsolve utilities
- Combine split test assertions for better readability
- Keep semantically related expressions on single lines under 120 chars

This follows Catalyst.jl PR #1306 formatting guidelines to improve readability
by avoiding unnecessary line splits that make code harder to follow.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas merged commit baec6f3 into master Aug 1, 2025
20 of 28 checks passed
@ChrisRackauckas ChrisRackauckas deleted the fix-formatter-line-splits branch August 1, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants