General updates #264
Open
General updates #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix nlopt_test.jl: Change maxeval from 100 to 10000 (was 100 - 000) - Fix multiple_shooting_objective_test.jl: Increase BFGS maxiters from 500 to 10000 These low iteration counts were likely causing test failures due to insufficient convergence. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- blackboxoptim_test.jl: Increase MaxSteps from 11e3 to 50e3 for 4-parameter optimization - weighted_loss_test.jl: Add maxeval\!(opt, 10000) for NLopt optimization These tests were still failing due to insufficient iterations for convergence. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Generate separate test data (data2, data3) for prob2 and prob3 - Update all tests to use correct data for each problem - Add random seed for reproducible test data - Increase BBO iterations for better convergence This fixes the issue where all parameter estimation tests were using data generated from prob1, causing incorrect parameter estimation for prob2 and prob3. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.