Skip to content

Make LinearVerbosity concrete #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

Make LinearVerbosity concrete #809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ee8e7
Fix abstract linear verbosity type
RomeoV Oct 30, 2025
e148a62
Fixup cache creation with specific types
RomeoV Oct 30, 2025
a4eaf46
Add `LinearVerbosity` type constraint
RomeoV Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ The cache automatically tracks when matrix `A` or parameters `p` change by setti
appropriate freshness flags. When `solve!` is called, stale cache entries are automatically
recomputed as needed.
"""
mutable struct LinearCache{TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, issq, S}
mutable struct LinearCache{TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, Tlv <: LinearVerbosity, issq, S}
A::TA
b::Tb
u::Tu
Expand All @@ -119,7 +119,7 @@ mutable struct LinearCache{TA, Tb, Tu, Tp, Talg, Tc, Tl, Tr, Ttol, issq, S}
abstol::Ttol
reltol::Ttol
maxiters::Int
verbose::LinearVerbosity
verbose::Tlv
assumptions::OperatorAssumptions{issq}
sensealg::S
end
Expand Down Expand Up @@ -385,7 +385,7 @@ function __init(prob::LinearProblem, alg::SciMLLinearSolveAlgorithm,
Tc = typeof(cacheval)

cache = LinearCache{typeof(A), typeof(b), typeof(u0_), typeof(p), typeof(alg), Tc,
typeof(Pl), typeof(Pr), typeof(reltol), typeof(assumptions.issq),
typeof(Pl), typeof(Pr), typeof(reltol), typeof(verbose_spec), typeof(assumptions.issq),
typeof(sensealg)}(
A, b, u0_, p, alg, cacheval, isfresh, precsisfresh, Pl, Pr, abstol, reltol,
maxiters, verbose_spec, assumptions, sensealg)
Expand Down
Loading