Skip to content

don't reset aliasing on reinit! #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 7, 2025
Merged

don't reset aliasing on reinit! #668

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
51f8e94
don't reset aliasing on reinit!
oscardssmith Aug 6, 2025
8f45a81
Update lib/NonlinearSolveQuasiNewton/src/solve.jl
ChrisRackauckas Aug 6, 2025
f6c616c
Update lib/NonlinearSolveSpectralMethods/src/solve.jl
ChrisRackauckas Aug 6, 2025
216722e
Update lib/NonlinearSolveFirstOrder/src/solve.jl
ChrisRackauckas Aug 6, 2025
32ab343
Update lib/NonlinearSolveFirstOrder/src/solve.jl
ChrisRackauckas Aug 6, 2025
aebcfc2
Update lib/NonlinearSolveSpectralMethods/src/solve.jl
ChrisRackauckas Aug 6, 2025
0b81f04
Update lib/NonlinearSolveFirstOrder/src/solve.jl
ChrisRackauckas Aug 7, 2025
16beb78
Update lib/NonlinearSolveQuasiNewton/src/solve.jl
ChrisRackauckas Aug 7, 2025
07a39e5
Update lib/NonlinearSolveSpectralMethods/src/solve.jl
ChrisRackauckas Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/NonlinearSolveFirstOrder/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ end

function InternalAPI.reinit_self!(
cache::GeneralizedFirstOrderAlgorithmCache, args...; p = cache.p, u0 = cache.u,
alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...
alias_u0::Bool = hasproperty(cache, :alias_u0) ? cache.alias_u0 : false,
maxiters = hasproperty(cache, :maxiters) ? cache.maxiters : 1000,
maxtime = hasproperty(cache, :maxtime) ? cache.maxtime : nothing, kwargs...
)
Utils.reinit_common!(cache, u0, p, alias_u0)

Expand Down
4 changes: 3 additions & 1 deletion lib/NonlinearSolveQuasiNewton/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ end

function InternalAPI.reinit_self!(
cache::QuasiNewtonCache, args...; p = cache.p, u0 = cache.u,
alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...
alias_u0::Bool = hasproperty(cache, :alias_u0) ? cache.alias_u0 : false,
maxiters = hasproperty(cache, :maxiters) ? cache.maxiters : 1000,
maxtime = hasproperty(cache, :maxtime) ? cache.maxtime : nothing, kwargs...
)
Utils.reinit_common!(cache, u0, p, alias_u0)

Expand Down
4 changes: 3 additions & 1 deletion lib/NonlinearSolveSpectralMethods/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ end

function InternalAPI.reinit_self!(
cache::GeneralizedDFSaneCache, args...; p = cache.p, u0 = cache.u,
alias_u0::Bool = false, maxiters = 1000, maxtime = nothing, kwargs...
alias_u0::Bool = hasproperty(cache, :alias_u0) ? cache.alias_u0 : false,
maxiters = hasproperty(maxiters, :maxiters) ? cache.maxiters : 1000,
maxtime = hasproperty(maxtime, :maxtime) ? cache.maxtime : nothing, kwargs...
)
Utils.reinit_common!(cache, u0, p, alias_u0)
T = eltype(u0)
Expand Down
Loading