Fix autodiff numerical stability issues in BrussScaling benchmark #1309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause Analysis
The issues identified in PR #1275 were not performance regressions but numerical instability problems:
Changes Made
1. Dependency Fixes
2. Regression Tests Added
test_bruss_regression.jl
: Comprehensive test suite to prevent future issues3. Documentation
Test Results
The fix resolves the numerical instability issues:
Test Plan
This fix addresses the numerical stability issues that were misidentified as performance regressions in the original analysis.
🤖 Generated with Claude Code