chef-workstation: Update to version 25.5.1084 #16071
Conversation
WalkthroughUpdates the Scoop manifest for Chef Workstation to version 25.5.1084, adjusts description text, updates MSI URL and hash, adds 7zip dependency, adds PowerShell setup notes for registry/permissions, and revises checkver to parse release notes while removing autoupdate hash verification. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Your changes do not pass checks. chef-workstation
|
LogicDaemon
force-pushed
the
master
branch
4 times, most recently
from
d6b6b07 to
44bb0db
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
bucket/chef-workstation.json (3)
2-3: Version bump looks good; minor copyedit in description.Consider “developer toolkit” (one word) and add the serial/Oxford comma: “Chef Infra, InSpec, and Habitat…”.
- "description": "Chef Workstation is Chef's modern developer tool kit that includes Chef Infra, InSpec and Habitat plus a host of resources, helpers and testing tools that make automating infrastructure, application and security testing easier than ever. Chef Workstation supersedes ChefDK.", + "description": "Chef Workstation is Chef's modern developer toolkit that includes Chef Infra, InSpec, and Habitat, plus resources, helpers, and testing tools that make automating infrastructure, application, and security testing easier than ever. Chef Workstation supersedes ChefDK.",
28-29: checkver source may be brittle; consider a more stable signal.Docs HTML structure can change. Prefer a JSON/API or upstream releases to reduce regex fragility.
- "checkver": { - "url": "https://docs.chef.io/release_notes_workstation/", - "regex": "id=[\\\"']?chef-workstation-release-notes[\\\"']?[\\s\\S]*?<h2\\s+id=[\\\"']?([0-9.]+)[\\\"']?" - }, + "checkver": { + "github": "chef/chef-workstation", + "regex": "v?([0-9.]+)" + },If you prefer to stay off GitHub, switch to a packages.chef.io manifest endpoint if available and parse JSON.
34-37: Add autoupdate hash retrieval to keep integrity checks on updates.This lets maintainers avoid manual hash updates while preserving verification.
"64bit": { - "url": "https://packages.chef.io/files/stable/chef-workstation/$version/windows/2022/chef-workstation-$version-1-x64.msi" + "url": "https://packages.chef.io/files/stable/chef-workstation/$version/windows/2022/chef-workstation-$version-1-x64.msi", + "hash": { + "url": "https://packages.chef.io/files/stable/chef-workstation/$version/windows/2022/chef-workstation-$version-1-x64.msi.sha256" + } }(Adjust the .sha256 path if Chef uses a different checksum filename.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
bucket/chef-workstation.json(2 hunks)
🔇 Additional comments (3)
bucket/chef-workstation.json (3)
15-20: Adding 7zip dependency is appropriate for Expand-7zipArchive.This aligns with the pre_install step; no action needed.
38-49: Narrow registry ACL in installer notes
- Replace FullControl on HKLM:\SOFTWARE\Progress with only the rights you need (SetValue ± CreateSubKey)
- Scope the rule to the specific subkey Chef writes (e.g., …\Progress\Authentication)
- For group grants, prefer “Users” over “Authenticated Users” with the same minimal rights
- Confirm on v25.5.1084 whether this registry tweak is still required; if not, prefix the note with “If you see Win32::Registry::Error: Access is denied…”
11-12: Checksum and URL verified
The SHA256 of the downloaded MSI matches the expected value. Merging is safe.
Closes #16070
<manifest-name[@version]|chore>: <general summary of the pull request>Added my fork as a bucket, then
scoop install bucket/chef-workstation— installed successfully.Summary by CodeRabbit