Vmr: Add version 0.7.5 #16159
Vmr: Add version 0.7.5 #16159
Conversation
WalkthroughAdds two new Scoop manifests: bucket/proto.json (Proto v0.52.5) with an installer script, env vars, PATH updates, and GitHub-based checkver/autoupdate; and bucket/vmr.json (VMR v0.7.5) defining 64-bit and arm64 assets with hashes, binary, and GitHub-based checkver/autoupdate. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Scoop
participant GitHub as GitHub Releases
participant FS as Filesystem/Env
rect rgba(227,241,255,0.5)
note over User,Scoop: Install Proto (bucket/proto.json)
User->>Scoop: scoop install proto
Scoop->>GitHub: Download proto.exe (win64)
Scoop->>FS: Create persist_dir/bin
Scoop->>FS: Move proto.exe -> persist_dir/bin
alt proto-shim.exe present
Scoop->>FS: Move proto-shim.exe -> persist_dir/bin
end
Scoop->>FS: Set PROTO_HOME=persist_dir
Scoop->>FS: Add persist_dir/bin to PATH
end
rect rgba(235,255,227,0.5)
note over User,Scoop: Install VMR (bucket/vmr.json)
User->>Scoop: scoop install vmr
Scoop->>GitHub: Download vmr.exe (win64/arm64)
Scoop->>FS: Place vmr.exe and register bin
end
rect rgba(255,245,227,0.5)
note over Scoop,GitHub: Version checks / autoupdate (both)
Scoop->>GitHub: Check latest release (checkver)
Scoop->>GitHub: Resolve asset URL(s) from $version (autoupdate)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. proto
vmr
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bucket/vmr.json (1)
20-29: Consider adding hash verification to autoupdate.The autoupdate section lacks hash verification URLs, which could compromise security during automatic updates. Consider adding a hash section similar to the Proto manifest.
"autoupdate": { "architecture": { "64bit": { "url": "https://github.com/gvcgo/version-manager/releases/download/v$version/vmr_windows-amd64.zip" }, "arm64": { "url": "https://github.com/gvcgo/version-manager/releases/download/v$version/vmr_windows-arm64.zip" } - } + }, + "hash": { + "url": "$baseurl/vmr_windows-$architecture.zip.sha256" + } }However, first verify if the VMR project provides SHA-256 files alongside their releases:
#!/bin/bash # Check if SHA-256 files are available for VMR releases echo "Checking for SHA-256 files in VMR v0.7.5 release..." curl -I "https://github.com/gvcgo/version-manager/releases/download/v0.7.5/vmr_windows-amd64.zip.sha256" 2>/dev/null | head -1 curl -I "https://github.com/gvcgo/version-manager/releases/download/v0.7.5/vmr_windows-arm64.zip.sha256" 2>/dev/null | head -1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
bucket/proto.json(1 hunks)bucket/vmr.json(1 hunks)
🔇 Additional comments (5)
bucket/vmr.json (2)
1-30: LGTM! Well-structured Scoop manifest for VMR version manager.The manifest follows Scoop conventions correctly with proper metadata, architecture-specific binaries, and GitHub-based version management. The structure aligns well with the companion Proto manifest in this PR.
8-9: SHA-256 hashes verified — match release assets.
Both vmr_windows-amd64.zip and vmr_windows-arm64.zip for gvcgo/version-manager v0.7.5 match the hashes in bucket/vmr.json (lines 8–9 and 12–13).bucket/proto.json (3)
1-44: LGTM! Well-structured Scoop manifest for Proto toolchain.The manifest correctly implements persistent storage for binaries, proper environment setup, and includes hash verification in autoupdate. The PowerShell installer script appropriately handles the binary relocation.
40-42: SHA-256 autoupdate URL verifiedConfirmed — the release asset URL pattern is valid (for v0.52.5 the URL returns HTTP 200 and the asset contains the expected SHA-256 checksum + filename). No change required in bucket/proto.json (lines 40–42).
8-9: SHA-256 verified — matches the Proto v0.52.5 Windows asset.bucket/proto.json (lines 8–9) — expected / actual: fdf3b65bb60930a7f454cb164ea86040ea28a62b8ee586b67672b9a145c01dc7.
Vmr: Add version 0.7.5
vmrfixs the configuration path as$HOME/.vmr, so persist dir for this is unnecessary.<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit