-
Notifications
You must be signed in to change notification settings - Fork 1.5k
rclone-ui: Add version 2.6.3 #16214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rclone-ui: Add version 2.6.3 #16214
Conversation
WalkthroughAdds a new Scoop JSON manifest Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Scoop as Scoop (bucket)
participant GH as GitHub Releases
participant Installer as Rclone UI Installer
participant Windows as Windows OS
User->>Scoop: scoop install rclone-ui
Scoop->>GH: Fetch release (checkver -> releases/tag/v{version})
GH-->>Scoop: Release assets (arch-specific URLs)
Scoop->>Scoop: Download asset (x64 or arm64)
Scoop->>Scoop: Verify SHA256
Scoop->>Scoop: Run pre_install cleanup (remove old files)
Scoop->>Installer: Run installer with /S /D=$dir
Installer->>Windows: Install files, create bin & shortcuts
Installer-->>Scoop: Exit code
Note over User,Scoop: If WebView2 missing, follow Evergreen Runtime guidance
User->>Scoop: scoop uninstall rclone-ui
Scoop->>Windows: Run Uninstall.exe /S
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with rclone-ui
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/rclone-ui.json (1)
3-3
: Tighten description phrasing (brand capitalization).
Consider capitalizing the brand and clarifying scope.- "description": "GUI for rclone & S3", + "description": "GUI for Rclone and cloud storage (incl. S3)",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/rclone-ui.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
🔇 Additional comments (6)
bucket/rclone-ui.json (6)
26-31
: LGTM on bin/shortcuts.
Shim name and shortcut look consistent with app name.
36-36
: checkver via GitHub is fine.
No issues; Scoop will track tags (v-prefixed).
37-46
: Approve — autoupdate URLs valid for v-prefixed tags
Confirmed upstream tags use the "v" prefix (latest: v2.6.1); no changes needed.
5-5
: License verified — Apache-2.0 matches upstream.
SPDX identifier in bucket/rclone-ui.json is correct.
32-35
: Declare Microsoft Edge WebView2 Runtime as an explicit dependency (if an Extras manifest exists).
Search of bucket/*.json found only notes referencing WebView2 (bucket/squirreldisk.json, bucket/tanoshi.json); no dedicated WebView2 manifest (e.g. microsoft-edge-webview2-runtime) was found. If an Extras manifest named "microsoft-edge-webview2-runtime" exists, add"depends": "microsoft-edge-webview2-runtime",
to bucket/rclone-ui.json; otherwise create a runtime manifest or keep the notes.
8-14
: Verify URLs and SHA256 hashes for x64 and arm64 EXEs.
Release assets for v2.6.1 exist; the sandbox downloaded Rclone.UI_x64.exe but sha256sum is unavailable here — compute SHA256 locally for Rclone.UI_x64.exe and Rclone.UI_arm64.exe and confirm they match the hashes in bucket/rclone-ui.json (lines 8–14) to prevent broken installs from hash/URL drift.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
bucket/rclone-ui.json (3)
1-53
: Reorder fields per Scoop Extras conventions; minor copy edits.Bring
notes
earlier, keep consistent field order, and prefer “and” over “&”.{ - "version": "2.6.1", - "description": "GUI for rclone & S3", - "homepage": "https://github.com/rclone-ui/rclone-ui", - "license": "Apache-2.0", - "architecture": { + "version": "2.6.1", + "description": "GUI for rclone and S3", + "homepage": "https://github.com/rclone-ui/rclone-ui", + "license": "Apache-2.0", + "notes": [ + "Requires Microsoft Edge WebView2 Runtime (preinstalled on Windows 11 and most Windows 10).", + "If missing, install the Evergreen Runtime from Microsoft." + ], + "architecture": { "64bit": { "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v2.6.1/Rclone.UI_x64.exe", "hash": "5d3e7918847ca072e3309ee8d77f5f7f7d22e92c5d72dc44d390c43497631314" }, "arm64": { "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v2.6.1/Rclone.UI_arm64.exe", "hash": "ad481aa5531bf78b0a379947feb662c27c52ad55a1a9c368e9cc5606e22f0bd4" } }, "installer": { "args": [ "/S", "/D=$dir" ] }, - "uninstaller": { - "file": "Uninstall.exe", - "args": "/S" - }, + "uninstaller": { + "file": "uninstall.exe", + "args": "/S" + }, "bin": [ [ "Rclone UI.exe", "rclone-ui" ] ], "shortcuts": [ [ "Rclone UI.exe", "Rclone UI" ] ], - "notes": [ - "Requires Microsoft Edge WebView2 Runtime (preinstalled on Windows 11 and most Windows 10).", - "If missing, install the Evergreen Runtime from Microsoft." - ], - "checkver": "github", + "checkver": { + "github": "rclone-ui/rclone-ui" + }, "autoupdate": { "architecture": { "64bit": { "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v$version/Rclone.UI_x64.exe" }, "arm64": { "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v$version/Rclone.UI_arm64.exe" } } } }
42-52
: Prefer explicit GitHub target in checkver; optional autoupdate hash.Explicitly set the repo in
checkver
. If upstream publishes checksums, consider addingautoupdate.hash
later.- "checkver": "github", + "checkver": { "github": "rclone-ui/rclone-ui" },
3-3
: Minor copyedit: avoid ampersand in description.Use “and” for consistency with other manifests.
- "description": "GUI for rclone & S3", + "description": "GUI for rclone and S3",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/rclone-ui.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
🔇 Additional comments (2)
bucket/rclone-ui.json (2)
22-25
: Uninstaller filename should beuninstall.exe
(NSIS/Tauri default).Rclone UI’s Tauri/NSIS bundle typically installs
uninstall.exe
(lowercase). Keep/S
.- "uninstaller": { - "file": "Uninstall.exe", - "args": "/S" - }, + "uninstaller": { + "file": "uninstall.exe", + "args": "/S" + },
6-15
: URLs match upstream assets; confirm SHA256 checksums
- bucket/rclone-ui.json: manifest URLs exactly match GitHub release assets for v2.6.1 (Rclone.UI_x64.exe, Rclone.UI_arm64.exe); no "-setup.exe" variants found.
- Action: download those two EXEs from the release and verify their SHA256 sum equals .architecture["64bit"].hash and .architecture.arm64.hash in bucket/rclone-ui.json.
Issue: #16248 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to the latest version.
Otherwise looks good.
/verify |
All changes look good. Wait for review from human collaborators. rclone-ui
|
<manifest-name[@version]|chore>: <general summary of the pull request>
Summary by CodeRabbit