Skip to content

Conversation

FTCHD
Copy link
Contributor

@FTCHD FTCHD commented Sep 23, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Added Rclone UI (v2.6.3) to the app catalog with Windows installer support.
    • Provides x64 and ARM64 builds with verified downloads and architecture-specific autoupdate URLs.
    • Supports silent install/uninstall, pre-install cleanup, and creates desktop/start menu shortcuts.
    • Notes Microsoft Edge WebView2 runtime requirement and guidance for Evergreen Runtime; autoupdate checks use GitHub releases.

Copy link

coderabbitai bot commented Sep 23, 2025

Walkthrough

Adds a new Scoop JSON manifest bucket/rclone-ui.json exporting a Windows installer manifest for Rclone UI v2.6.3 with x64 and arm64 releases, hashes, pre-install cleanup, bin/shortcut mappings, WebView2 notes, GitHub-based checkver, and autoupdate URL templates.

Changes

Cohort / File(s) Summary
New public installer manifest
bucket/rclone-ui.json
Adds a new Scoop-style manifest for Rclone UI v2.6.3 with description, homepage, license, user notes about Edge WebView2/Evergreen Runtime; architecture-specific download entries for 64bit and arm64 (URLs + SHA256); a pre_install cleanup command; bin and shortcuts mappings; checkver configured to GitHub releases; and autoupdate URL templates parameterized by version and architecture.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Scoop as Scoop (bucket)
  participant GH as GitHub Releases
  participant Installer as Rclone UI Installer
  participant Windows as Windows OS

  User->>Scoop: scoop install rclone-ui
  Scoop->>GH: Fetch release (checkver -> releases/tag/v{version})
  GH-->>Scoop: Release assets (arch-specific URLs)
  Scoop->>Scoop: Download asset (x64 or arm64)
  Scoop->>Scoop: Verify SHA256
  Scoop->>Scoop: Run pre_install cleanup (remove old files)
  Scoop->>Installer: Run installer with /S /D=$dir
  Installer->>Windows: Install files, create bin & shortcuts
  Installer-->>Scoop: Exit code
  Note over User,Scoop: If WebView2 missing, follow Evergreen Runtime guidance
  User->>Scoop: scoop uninstall rclone-ui
  Scoop->>Windows: Run Uninstall.exe /S
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hopped through hashes, soft and neat,
A tiny manifest for users to meet.
Downloads sorted, shortcuts aligned,
WebView2 whispered, "All combined."
Installer set — a joyous leap! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description only lists checklist items and does not include a summary of the changes, context for the manifest addition, or any issue reference as indicated in the repository’s description template. Please expand the pull request description to include a brief summary of what the new manifest does, any related issue numbers using “Closes #” or “Relates to #”, and any relevant installation or usage notes following the template’s structure.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title clearly identifies the manifest being added and the updated version number, concisely reflecting the primary change in the pull request without unnecessary detail or ambiguity.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

rclone-ui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/rclone-ui.json (1)

3-3: Tighten description phrasing (brand capitalization).
Consider capitalizing the brand and clarifying scope.

-  "description": "GUI for rclone & S3",
+  "description": "GUI for Rclone and cloud storage (incl. S3)",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a132a4 and 388ac41.

📒 Files selected for processing (1)
  • bucket/rclone-ui.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
🔇 Additional comments (6)
bucket/rclone-ui.json (6)

26-31: LGTM on bin/shortcuts.
Shim name and shortcut look consistent with app name.


36-36: checkver via GitHub is fine.
No issues; Scoop will track tags (v-prefixed).


37-46: Approve — autoupdate URLs valid for v-prefixed tags
Confirmed upstream tags use the "v" prefix (latest: v2.6.1); no changes needed.


5-5: License verified — Apache-2.0 matches upstream.
SPDX identifier in bucket/rclone-ui.json is correct.


32-35: Declare Microsoft Edge WebView2 Runtime as an explicit dependency (if an Extras manifest exists).
Search of bucket/*.json found only notes referencing WebView2 (bucket/squirreldisk.json, bucket/tanoshi.json); no dedicated WebView2 manifest (e.g. microsoft-edge-webview2-runtime) was found. If an Extras manifest named "microsoft-edge-webview2-runtime" exists, add "depends": "microsoft-edge-webview2-runtime", to bucket/rclone-ui.json; otherwise create a runtime manifest or keep the notes.


8-14: Verify URLs and SHA256 hashes for x64 and arm64 EXEs.
Release assets for v2.6.1 exist; the sandbox downloaded Rclone.UI_x64.exe but sha256sum is unavailable here — compute SHA256 locally for Rclone.UI_x64.exe and Rclone.UI_arm64.exe and confirm they match the hashes in bucket/rclone-ui.json (lines 8–14) to prevent broken installs from hash/URL drift.

@SorYoshino
Copy link
Contributor

  • Please adjust the indentation, formatting, and field order according to the Contributing Guide.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
bucket/rclone-ui.json (3)

1-53: Reorder fields per Scoop Extras conventions; minor copy edits.

Bring notes earlier, keep consistent field order, and prefer “and” over “&”.

 {
-    "version": "2.6.1",
-    "description": "GUI for rclone & S3",
-    "homepage": "https://github.com/rclone-ui/rclone-ui",
-    "license": "Apache-2.0",
-    "architecture": {
+    "version": "2.6.1",
+    "description": "GUI for rclone and S3",
+    "homepage": "https://github.com/rclone-ui/rclone-ui",
+    "license": "Apache-2.0",
+    "notes": [
+        "Requires Microsoft Edge WebView2 Runtime (preinstalled on Windows 11 and most Windows 10).",
+        "If missing, install the Evergreen Runtime from Microsoft."
+    ],
+    "architecture": {
         "64bit": {
             "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v2.6.1/Rclone.UI_x64.exe",
             "hash": "5d3e7918847ca072e3309ee8d77f5f7f7d22e92c5d72dc44d390c43497631314"
         },
         "arm64": {
             "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v2.6.1/Rclone.UI_arm64.exe",
             "hash": "ad481aa5531bf78b0a379947feb662c27c52ad55a1a9c368e9cc5606e22f0bd4"
         }
     },
     "installer": {
         "args": [
             "/S",
             "/D=$dir"
         ]
     },
-    "uninstaller": {
-        "file": "Uninstall.exe",
-        "args": "/S"
-    },
+    "uninstaller": {
+        "file": "uninstall.exe",
+        "args": "/S"
+    },
     "bin": [
         [
             "Rclone UI.exe",
             "rclone-ui"
         ]
     ],
     "shortcuts": [
         [
             "Rclone UI.exe",
             "Rclone UI"
         ]
     ],
-    "notes": [
-        "Requires Microsoft Edge WebView2 Runtime (preinstalled on Windows 11 and most Windows 10).",
-        "If missing, install the Evergreen Runtime from Microsoft."
-    ],
-    "checkver": "github",
+    "checkver": {
+        "github": "rclone-ui/rclone-ui"
+    },
     "autoupdate": {
         "architecture": {
             "64bit": {
                 "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v$version/Rclone.UI_x64.exe"
             },
             "arm64": {
                 "url": "https://github.com/rclone-ui/rclone-ui/releases/download/v$version/Rclone.UI_arm64.exe"
             }
         }
     }
 }

42-52: Prefer explicit GitHub target in checkver; optional autoupdate hash.

Explicitly set the repo in checkver. If upstream publishes checksums, consider adding autoupdate.hash later.

-    "checkver": "github",
+    "checkver": { "github": "rclone-ui/rclone-ui" },

3-3: Minor copyedit: avoid ampersand in description.

Use “and” for consistency with other manifests.

-    "description": "GUI for rclone & S3",
+    "description": "GUI for rclone and S3",
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 388ac41 and 1ec05c5.

📒 Files selected for processing (1)
  • bucket/rclone-ui.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gitoffthelawn
PR: ScoopInstaller/Extras#16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
🔇 Additional comments (2)
bucket/rclone-ui.json (2)

22-25: Uninstaller filename should be uninstall.exe (NSIS/Tauri default).

Rclone UI’s Tauri/NSIS bundle typically installs uninstall.exe (lowercase). Keep /S.

-    "uninstaller": {
-        "file": "Uninstall.exe",
-        "args": "/S"
-    },
+    "uninstaller": {
+        "file": "uninstall.exe",
+        "args": "/S"
+    },

6-15: URLs match upstream assets; confirm SHA256 checksums

  • bucket/rclone-ui.json: manifest URLs exactly match GitHub release assets for v2.6.1 (Rclone.UI_x64.exe, Rclone.UI_arm64.exe); no "-setup.exe" variants found.
  • Action: download those two EXEs from the release and verify their SHA256 sum equals .architecture["64bit"].hash and .architecture.arm64.hash in bucket/rclone-ui.json.

@FTCHD
Copy link
Contributor Author

FTCHD commented Sep 29, 2025

Issue: #16248

@aliesbelik aliesbelik linked an issue Sep 29, 2025 that may be closed by this pull request
6 tasks
@aliesbelik aliesbelik removed the package-request-needed Need package-request issue label Sep 29, 2025
Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not run NSIS installer directly, extract via 7-Zip instead and remove unnecessary files.
See e.g. qemu or krita manifests for reference.

@aliesbelik aliesbelik changed the title Rclone UI: Add version 2.6.1 rclone-ui: Add version 2.6.1 Oct 2, 2025
@FTCHD FTCHD requested a review from aliesbelik October 2, 2025 03:21
Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to the latest version.
Otherwise looks good.

@FTCHD FTCHD requested a review from aliesbelik October 2, 2025 15:38
@aliesbelik aliesbelik changed the title rclone-ui: Add version 2.6.1 rclone-ui: Add version 2.6.3 Oct 2, 2025
@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

github-actions bot commented Oct 2, 2025

All changes look good.

Wait for review from human collaborators.

rclone-ui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@aliesbelik aliesbelik merged commit f18bbe2 into ScoopInstaller:master Oct 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] rclone-ui
3 participants