Skip to content

Conversation

oxygen-dioxide
Copy link
Contributor

@oxygen-dioxide oxygen-dioxide commented Sep 26, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Adds support to install KingDraw on Windows via the package manager.
    • Downloads and verifies the official installer, ensuring integrity before installation.
    • Automatically extracts the application archive and sets up the app for use.
    • Creates desktop and start-menu shortcuts for quick access and includes license, version, homepage, and checksum metadata.

Copy link

coderabbitai bot commented Sep 26, 2025

Walkthrough

Added a new Scoop-style JSON manifest bucket/kingdraw.json providing metadata for the KingDraw Windows installer: license, description, homepage, installer URL, version, SHA256 hash, bin mapping, shortcuts, and a pre_install step to extract a 7zip archive.

Changes

Cohort / File(s) Summary
Manifest addition
bucket/kingdraw.json
Added JSON manifest for KingDraw containing license (Freeware, URL), description, homepage, installer URL, version, SHA256 hash, bin mapping, shortcuts, and a pre_install step to expand a 7zip archive.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibble through JSON with whiskers of care,
A manifest appears—KingDraw’s in the air!
Hashes aligned, bins mapped just right,
Pre_install pops archives light.
One tiny file, a tidy delight—hip hop! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is merely the template placeholders without any actual summary of the changes or details about the new manifest version, and it lacks a filled general summary section or linked issue information as outlined by the template. Please replace the template comments with a concise summary of what this PR changes, specify any related issue under “Closes #XXXX” or “Relates to #XXXX” if applicable, and ensure all required template sections are properly filled.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Kingdraw: Add version 3.0.2.20” clearly summarizes the primary change of introducing a new version for the Kingdraw manifest, follows the repository’s conventional format, and is both concise and specific enough for maintainers to understand at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61cd862 and 4412563.

📒 Files selected for processing (1)
  • bucket/kingdraw.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/kingdraw.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

kingdraw

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb08d90 and 9f9e1f1.

📒 Files selected for processing (1)
  • bucket/kingdraw.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

@aliesbelik aliesbelik added the package-request-needed Need package-request issue label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants