-
Notifications
You must be signed in to change notification settings - Fork 1.5k
proton-drive: Add version 1.11.4 #16258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new Scoop manifest bucket/proton-drive.json for Proton Drive v1.11.4, defining metadata, architecture-specific download URLs and hashes, an installer script to extract MSI contents and relocate files, a shortcut, version check via webpage regex, and autoupdate URL templates for 64-bit and ARM64. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Scoop as Scoop (Manifest)
participant Web as Proton Download Site
participant PS as Installer Script
participant FS as File System
User->>Scoop: scoop install proton-drive
Scoop->>Web: GET installer (arch-specific URL)
Web-->>Scoop: EXE payload
Scoop->>PS: Run installer script
PS->>FS: Expand-7zipArchive to $dir
PS->>FS: msiextract *.msi to $dir
PS->>FS: Move "Proton Drive" directory into $dir
PS->>FS: Remove extracted MSI and temp files
PS-->>Scoop: Installation complete
Note over Scoop,FS: Shortcut: ProtonDrive.exe → "Proton Drive"
User->>Scoop: scoop update proton-drive
Scoop->>Web: GET checkver URL
Web-->>Scoop: HTML content
Scoop->>Scoop: Regex extract version
Scoop->>Web: Construct autoupdate URL (per arch)
Web-->>Scoop: New EXE payload (if version changed)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All changes look good. Wait for review from human collaborators. proton-drive
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/proton-drive.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
"version": "1.11.4", | ||
"description": "Free end-to-end encrypted cloud storage made by Proton AG", | ||
"homepage": "https://proton.me/drive", | ||
"license": "GPL-3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect license declaration.
Proton Drive’s Windows client is distributed under a proprietary EULA, not GPL-3.0, so the manifest’s license value is inaccurate and misleads users. Update the field to the correct license (e.g., "Proprietary"
).
- "license": "GPL-3.0",
+ "license": "Proprietary",
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"license": "GPL-3.0", | |
"license": "Proprietary", |
🤖 Prompt for AI Agents
In bucket/proton-drive.json around line 5, the manifest incorrectly declares
"license": "GPL-3.0"; change this value to the correct license string (for
example "Proprietary") to reflect Proton Drive’s actual EULA—open the JSON file,
replace the license value with the correct identifier, and ensure the file
remains valid JSON (keep quotes and trailing commas consistent with surrounding
entries).
Closes #11582
<manifest-name[@version]|chore>: <general summary of the pull request>
Summary by CodeRabbit