Skip to content

Conversation

zeldrisho
Copy link
Contributor

@zeldrisho zeldrisho commented Oct 2, 2025

Closes #14390

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features

    • Added Proton Pass (v1.32.7) to the app catalog, making it available for installation via the package manager.
    • Creates a desktop/start menu shortcut labeled “Proton Pass” after installation.
    • Enables automatic version checking and streamlined updates for future releases.
    • Ensures verified downloads with integrity checks.
  • Chores

    • Included metadata (description, homepage, license) to improve app discoverability.

Copy link

coderabbitai bot commented Oct 2, 2025

Walkthrough

Adds a new Scoop manifest bucket/proton-pass.json for Proton Pass (v1.32.7) with metadata, download URL and SHA256, extraction directory, shortcut, checkver (version.json with regex), and autoupdate URL template.

Changes

Cohort / File(s) Summary of edits
Scoop manifest: Proton Pass
bucket/proton-pass.json
Added new manifest defining version 1.32.7, metadata (description, homepage, GPL-3.0), installer URL and hash, extract_dir, shortcut for ProtonPass.exe, checkver via version.json with regex, and autoupdate template URL.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor User
    participant Scoop as Scoop CLI
    participant Manifest as proton-pass.json
    participant Server as proton.me server
    participant OS as System

    User->>Scoop: scoop install proton-pass
    Scoop->>Manifest: Read metadata (URL, hash, extract_dir, shortcut)
    Scoop->>Server: Download ProtonPass_Setup_[version].exe
    Server-->>Scoop: Installer binary
    Scoop->>OS: Verify SHA256, extract to extract_dir
    OS-->>Scoop: Files available
    Scoop->>OS: Create shortcut "Proton Pass" -> ProtonPass.exe
    Note over Scoop,OS: Installation completed

    User->>Scoop: scoop checkup / update
    Scoop->>Manifest: checkver (fetch version.json, apply regex)
    Scoop->>Server: Get latest Version from version.json
    Server-->>Scoop: {"Version":"x.y.z"}
    alt Newer version available
        Scoop->>Manifest: Use autoupdate URL template
    else Up-to-date
        Note over Scoop: No update action
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of JSON, a hop and a pass,
I tucked a manifest into Scoop’s grass.
Shortcuts set, hashes tight—no sass,
Checkver peeks through versioned glass.
With whiskers twitching, I tap and class:
“Proton’s ready—install en masse!” 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly identifies the manifest name and version in the conventional format and directly reflects the core change of adding version 1.32.7 to the proton-pass manifest.
Linked Issues Check ✅ Passed The new scoop manifest adds version 1.32.7 with correct metadata, download URL, hash, checkver, and autoupdate settings, fully addressing the objectives from issue #14390.
Out of Scope Changes Check ✅ Passed The PR only introduces the proton-pass manifest file and does not touch any other components, so there are no out-of-scope changes.
Description Check ✅ Passed The pull request description follows the repository template by including the closing issue reference and completed checklist items, satisfying the required sections and demonstrating adherence to the contributing guidelines.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc1315f and 5c6ed0d.

📒 Files selected for processing (1)
  • bucket/proton-pass.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
bucket/proton-pass.json (1)

1-22: Manifest looks correct.

All required Scoop fields are present and align with Proton Pass’s upstream artifacts and versioning scheme.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

github-actions bot commented Oct 2, 2025

All changes look good.

Wait for review from human collaborators.

proton-pass

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: proton-pass
1 participant