Skip to content

Conversation

@kieranbenton
Copy link

@kieranbenton kieranbenton commented Aug 19, 2025

Reproduces #216

Beware - ive found that this test (and others?) flap, no doubt because the unit tests are running by default with some parallelism.

If you run this unit test in isolation it fails 100% of the time.

@SebastianStehle
Copy link
Owner

Tyvm. Please check the formatting of other tests and see if you rely need that much mjml to reproduce it.

@kieranbenton
Copy link
Author

Tyvm. Please check the formatting of other tests and see if you rely need that much mjml to reproduce it.

Not sure what you mean about formatting of other tests? I found Should_produce_deterministic_results which seemed appropriate and have added a test alongside that?

@SebastianStehle
Copy link
Owner

But the mjml formatting is super hard to read. I actually think the problek is that the second example contains the mjml twice, which caused a reuse of some buffers. But it too me ages to see that because the mjml is just one long line. The errors in the second block probably do not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants