Skip to content

Prevent InferecePools from being spawned for the same inference_pool_gid #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent InferecePools from being spawned for the same inference_pool_gid #2275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions mlserver/parallel/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,15 @@ async def _get_or_create_with_tarball(self, model: MLModel) -> InferencePool:
)

if not env_tarball:
return (
self._pools.setdefault(
inference_pool_gid,
InferencePool(self._settings, on_worker_stop=self._on_worker_stop),
if not inference_pool_gid:
return self._default_pool

if inference_pool_gid not in self._pools:
self._pools[inference_pool_gid] = InferencePool(
self._settings, on_worker_stop=self._on_worker_stop
)
if inference_pool_gid
else self._default_pool
)

return self._pools[inference_pool_gid]

env_hash = await compute_hash_of_file(env_tarball)
if inference_pool_gid is not None:
Expand Down