Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 30, 2025

Commit 311de37 introduced TankAlarm-112025-Common as a shared library and refactored all three sketches to use it, but didn't update the CI workflow. Compilation fails because Arduino CLI can't find the library headers.

Changes:

  • Added --library TankAlarm-112025-Common flag to all three compile commands in .github/workflows/arduino-ci-112025.yml
  • Added TankAlarm-112025-Common/** to workflow trigger paths
# Before
arduino-cli compile --fqbn arduino:mbed_opta:opta \
  TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino

# After  
arduino-cli compile --fqbn arduino:mbed_opta:opta \
  --library TankAlarm-112025-Common \
  TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino
Original prompt

This section details on the original issue you should resolve

<issue_title>Arduino Compilation Error in Multiple Sketches (112025) (2025-12-30)</issue_title>
<issue_description>## Arduino Compilation Failed - TankAlarm 112025

The Arduino code compilation failed for the TankAlarm-112025 (Blues Opta) projects.

Workflow Run: https://github.com/SenaxInc/ArduinoSMSTankAlarm/actions/runs/20603218262
Commit: 311de37
Branch: master

Details

TankAlarm-112025 (Arduino Opta)

  • Client Sketch: TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino ❌
  • Server Sketch: TankAlarm-112025-Server-BluesOpta/TankAlarm-112025-Server-BluesOpta.ino ❌
  • Viewer Sketch: TankAlarm-112025-Viewer-BluesOpta/TankAlarm-112025-Viewer-BluesOpta.ino ❌

Board:

  • Arduino Opta (arduino:mbed_opta:opta)

Triggered by: push

Next Steps

  1. Review the workflow logs for detailed error messages
  2. Fix compilation errors in the Arduino code
  3. Re-run the workflow to verify the fix

/cc @copilot</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Add --library TankAlarm-112025-Common flag to all three sketch compilations
and include TankAlarm-112025-Common in workflow trigger paths

Co-authored-by: dorkmo <1923070+dorkmo@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Arduino compilation errors in TankAlarm project Fix Arduino CI workflow to include TankAlarm-112025-Common library Dec 30, 2025
Copilot AI requested a review from dorkmo December 30, 2025 18:38
@dorkmo dorkmo marked this pull request as ready for review December 30, 2025 19:21
Copilot AI review requested due to automatic review settings December 30, 2025 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Arduino CI workflow compilation failures introduced in commit 311de37 by adding the required TankAlarm-112025-Common library reference. The workflow was failing because Arduino CLI couldn't locate the shared library headers that all three sketches depend on.

Key changes:

  • Added --library TankAlarm-112025-Common flag to all three Arduino CLI compile commands
  • Added TankAlarm-112025-Common/** to workflow trigger paths for both push and pull_request events

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dorkmo dorkmo merged commit 650283b into master Dec 30, 2025
6 of 7 checks passed
@dorkmo dorkmo deleted the copilot/fix-arduino-compilation-errors branch December 30, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arduino Compilation Error in Multiple Sketches (112025) (2025-12-30)

2 participants