Skip to content

Make Record default move constructible #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make Record default move constructible #95

wants to merge 1 commit into from

Conversation

@3XX0
Copy link

@3XX0 3XX0 commented May 23, 2018

This allows move-constructing Records in C++11 and above

@SergiusTheBest
Copy link
Owner

Hi!

I think Record is never copied or moved. Where do we need that?

@3XX0
Copy link
Author

3XX0 commented May 23, 2018

This isn't used in plog itself but this is useful for the application developer.
For example if one wants to save Records in standard containers (say a std::vector<Record>) to defer logging.

@SergiusTheBest
Copy link
Owner

Yes, it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@3XX0 @SergiusTheBest