[DO NOT MERGE] - [WIP] Release the React Router template #6163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Test suite run success3054 tests passing in 1315 suites. Report generated by 🧪jest coverage report action from 7b0c428 |
byrichardpowell
force-pushed
the
release-react-router-template
branch
from
3e6f51a to
fd44236
Compare
byrichardpowell
commented
Jul 25, 2025
| @@ -596,7 +596,7 @@ FLAGS | |||
| --flavor=<value> Which flavor of the given template to use. | |||
| --no-color Disable color output. | |||
| --template=<value> The app template. Accepts one of the following: | |||
| - <remix|none> | |||
| - <reactRouter|remix|none> | |||
There was a problem hiding this comment.
Kept support for remix flag so that its not a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The React Router template will become the recommended template
WHAT is this pull request doing?
Swap Remix for React Router
How to test your changes?
p shopify app initPost-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist