add support for rv version manager #3878
Open
+201
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rafaelfranca
reviewed
Jan 7, 2026
Comment on lines
+29
to
+31
| vscode.Uri.file("/home/linuxbrew/.linuxbrew/bin"), | ||
| vscode.Uri.file("/usr/local/bin"), | ||
| vscode.Uri.file("/opt/homebrew/bin"), |
Member
There was a problem hiding this comment.
Should we be using joinPath like we are doing in all other places we build paths?
Contributor
Author
There was a problem hiding this comment.
I noticed you've created a new PR (#3894) that refactors a lot of the version managers code. Should I wait for that to merge and then align this PR with the new pattern?
Member
There was a problem hiding this comment.
Let's finish this one and then I rebase mine.
rafaelfranca
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding support for rv as a version manager on vscode extension
closes #3861
Implementation
Automated Tests
Manual Tests