Skip to content

Check deployment checks before CD delayed #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
timothysmith0609 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Check deployment checks before CD delayed #1439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7c86f
Check deployment checks before CD delayed
timothysmith0609 Nov 24, 2025
4f939f2
move code around
timothysmith0609 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions app/views/shipit/stacks/_banners.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,18 @@
</div>
<% end %>

<% if stack.continuous_delivery_delayed? %>
<% if !stack.deployment_checks_passed? %>
<div class="banner banner--orange">
<div class="banner__inner wrapper">
<div class="banner__content">
<h2 class="banner__title">Stack has been locked by external system!</h2>
<p class = "banner__text">
<%= simple_format(deployment_checks_message(stack)) %>
</p>
</div>
</div>
</div>
<% elsif stack.continuous_delivery_delayed? %>
<div class="banner">
<div class="banner__inner wrapper">
<div class="banner__content">
Expand All @@ -76,15 +87,4 @@
</div>
</div>
</div>
<% elsif !stack.deployment_checks_passed? %>
<div class="banner banner--orange">
<div class="banner__inner wrapper">
<div class="banner__content">
<h2 class="banner__title">Stack has been locked by external system!</h2>
<p class = "banner__text">
<%= simple_format(deployment_checks_message(stack)) %>
</p>
</div>
</div>
</div>
<% end %>