remove extra fields on Discount API #3695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhamel4
force-pushed
the
jh_remove-extra-fields
branch
from
f6fdad2 to
1ae476f
Compare
jonathanhamel4
commented
Jan 5, 2026
| '@shopify/ui-extensions': patch | ||
| --- | ||
|
|
||
| Remove unsupported fields for the Discount API. Those fields will be added in a later API. |
Contributor
Author
There was a problem hiding this comment.
I made it a patch because those fields have merged, but it has not published yet. It was merged before the break.
jonathanhamel4
changed the title
devisscher
approved these changes
Jan 5, 2026
jonathanhamel4
force-pushed
the
jh_remove-extra-fields
branch
from
1ae476f to
397d749
Compare
Contributor
Author
|
@vividviolet , would we be okay to merge this change for 2026-01 ? |
Member
|
Yes, let's remove these if they will not be yet be supported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Removes fields that are not yet supported for discount api 2026-01. Those were not added yet to any release.
It is based on this comment https://github.com/Shopify/ui-extensions/pull/3641/files#r2662549011