Task/thdubois/gh 45/update testlib #153
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b51b795. Relate-to: SiliconLabsSoftware#26 Origin: SiliconLabsSoftware#27 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
One would argue that libs2 warnings should not be addressed in the consumming project, but until a better architecture is in place, we can enable it to detect issues and help fixing them at the root. If for any reason having this patch is a problem, I encourage to cherry-pick the 1st Bypass change (that would be applied in next release) This reverts commit 436ef26. Origin: SiliconLabsSoftware#37 Relate-to: SiliconLabsSoftware#28 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
After further investigations, the reason that script failed to use the git describe in github it because of a bug in related github action Relate-to: actions/checkout#2081 Origin: SiliconLabsSoftware#42 Relate-to: SiliconLabsSoftware#35 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Origin: SiliconLabsSoftware#42 Relate-to: Relate-to: SiliconLabsSoftware#35 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
This is something that should have been removed in latest release. It would be nice to release a revision version, this will help also derivates projects to importing ver_1.7.1 ? Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
The current version has issues but not impacting 64 bits system unsafe-libyaml unaligned write of u64 on 32-bit and 16-bit platforms zpc-1.7.0 does not fully support 32 bits systems so the risk was mitigated For the record it can natively build on i386, i will update build-rootfs.sh in upcoming patch. Origin: SiliconLabsSoftware#38 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
This text was generated from application, it should have been part of latest release, but wasn't due to time constraints. Origin: SiliconLabsSoftware#45 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…nder ThirdParty directory (SiliconLabsSoftware#51) libS2 now depends on two pathes from Zwave Stack : - ZWAVE_INCLUDE_DIR for all API include files - ZWAVE_CLASSCMD_DIR for ZW_classcmd.h file (cherry picked from commit 085d0c280bf0e187327f6c3e9542693eb097f54b) Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…are#51) (cherry picked from commit 0118850059796a045285e5702a2d713c6f19352f) Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ath (SiliconLabsSoftware#51) (cherry picked from commit bd9c072ab205d3745c64b09ccb9646fef7923abd) Last-Update: 2025-04-04 Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For the record following changes were shared: bd9c072a SWPROT-9264: Update libs2 Jenkinsfile with ZW_classcmd.h new path 01188500 SWPROT-9272: Correct NLS Support advertising 085d0c28 SWPROT-9264: Store ZW_classcmd.h in a generated subdirectory under ThirdParty directory. Relate-to: SiliconLabsSoftware#50 Origin: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…absSoftware#57) (cherry picked from commit 299c26d472c31e68f0d38734aee17304aa1690b9) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…liconLabsSoftware#57) (cherry picked from commit 76628f725482047b6977f49a039aa4a0cba9c81f) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…iliconLabsSoftware#57) (cherry picked from commit 5eec29c36e46c0069058e64dbd108cce51c1f35f) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…liconLabsSoftware#57) removed unity_print as it's useless on x86 and unit tests only run on x86 nowadays (cherry picked from commit cc1e9bd53e9abeab1702212a33182192663cad81) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ROSS_SYSTEM_DIR (SiliconLabsSoftware#57) (cherry picked from commit 83e42131435e21ab70b2f77437a6befe4c4ac4c6) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…Software#57) (cherry picked from commit 31d1548bf29264b269c29b2de797ca851835dae4) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…conLabsSoftware#57) (cherry picked from commit 14cfec5114348a72879e63b308e083d468828be1) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…liconLabsSoftware#57) (cherry picked from commit d8b0a256fca227a1de99b714361a7a5b4e4cc0eb) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…are#57) (cherry picked from commit 417b42ec16b4a7f796bce61a0f80fa59c5011e8f) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…SiliconLabsSoftware#57) (cherry picked from commit 81b502d3c534f964958a4e9d76f6943d5a37562c) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…as outdated (SiliconLabsSoftware#57) remove unity bundled with TestFramwork as it was outdated, we are now using the unity bundled with cmock in ThirdParty/cmock/vendor/unity. libs2 standalone unit tests were updated as well. (cherry picked from commit ba375ff2e7580da7a716697a5d39922adc09e888) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…re#57) (cherry picked from commit 0373e516a419f51058c4c04e7d382a1fca81dbde) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
SiliconLabsSoftware#57) (cherry picked from commit 18907993164d71d8fba9a276a6df682ab6b9fd89) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…er.py (SiliconLabsSoftware#57) the Docker image running as agent in UnifySDK CI does not have the python executable installed, this change prevents this kind of error from happening again (cherry picked from commit ccbd3fb30b7edfa51db0553f8df90c84a3a54184) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For some reason those changes were not aligned from libs2 import. Relate-to: SiliconLabsSoftware#50 Origin: SiliconLabsSoftware#57 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…iliconLabsSoftware#59) Observed issue on ver_1.7.0-27-g1302b2a5 was: docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main unable to prepare context: unable to 'git clone' to temporary context directory: \ error initializing submodules: fatal: No url found for submodule path \ 'applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock' in .gitmodules This was done using: git submodule add --force \ https://github.com/throwtheswitch/cmock \ applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock git -C applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock \ checkout v2.5.3-g9d092898 Relate-to: SiliconLabsSoftware#57 (comment) Relate-to: SiliconLabsSoftware#50 Origin: SiliconLabsSoftware#59 Relate-to: SiliconLabsSoftware#60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…nLabsSoftware#52) (cherry picked from commit 6d87a823ccc19bd113f52b8f546c1759efc2d684) Forwarded: SiliconLabsSoftware#52 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…in controller's NVM (SiliconLabsSoftware#52) (cherry picked from commit d925294748422d314bf58b9d8e67d04efab3aa97) Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#52 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
testlib doesn't use the attribute store. All related NLS storage code must be disabled for the testlib to compile. Create another library zwave_s2_testlib that doesn't contains attribute store related code. Last-Update: 2025-05-22
…tlib Create zwave_controller_testlib specifically to compile testlib. Keep all functionalities in zwave_controller lib
Keep functionnalities in zwave_rx and create zwave_rx_testlib specifically to compile testlib
Restore zwave_network_management lib functionnalities that were removed to compile testlib and create zwave_network_management_testlib to be able to compile testlib.
This reverts commit 86dd2bba208fc85f256b451a8b7cb9d9b4acea98. Last-Update: 2025-05-22
Fixes commit: 3d21e22f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Checklist