Skip to content

Added support for plural strings in ExprtextOf #8225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev/patch
Choose a base branch
from
Open

Added support for plural strings in ExprtextOf #8225

wants to merge 2 commits into from

Conversation

CJH3139
Copy link
Contributor

@CJH3139 CJH3139 commented Oct 5, 2025

Problem

#8176

Solution

  • In the acceptChange SET case, changed accepted type from String.class to String[].class
  • Made an Array copy of delta and joined the list using "\n" to combine multiple strings into a single string value.

Testing Completed

Added on to ExprTextOf.sk (Lines 26-36)

Supporting Information

Completes: #8176
Related: none

@CJH3139 CJH3139 requested a review from a team as a code owner October 5, 2025 21:04
@CJH3139 CJH3139 requested review from Burbulinis and cheeezburga and removed request for a team October 5, 2025 21:04
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 5, 2025
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch October 5, 2025 21:06
@sovdeeth sovdeeth changed the base branch from dev/patch to dev/feature October 5, 2025 21:06
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 5, 2025
@sovdeeth sovdeeth linked an issue Oct 5, 2025 that may be closed by this pull request
Add support for plural strings in ExprtextOf #8176
Open
1 task
@sovdeeth sovdeeth moved this to In Review in 2.13 Releases Oct 5, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Oct 5, 2025
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Oct 5, 2025
@sovdeeth sovdeeth added the don't merge me !! For pull requests that should not be merged due to some outstanding dispute, conflict or dependency. label Oct 6, 2025
@sovdeeth sovdeeth removed the don't merge me !! For pull requests that should not be merged due to some outstanding dispute, conflict or dependency. label Oct 15, 2025
@APickledWalrus APickledWalrus moved this to Awaiting Merge in 2.14 Releases Oct 15, 2025
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch October 16, 2025 20:27
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@TheMug06 TheMug06 TheMug06 approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

@Burbulinis Burbulinis Awaiting requested review from Burbulinis Burbulinis is a code owner automatically assigned from SkriptLang/core-developers

@Efnilite Efnilite Awaiting requested review from Efnilite

Assignees

No one assigned

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

2.14 Releases
Status: Awaiting Merge

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for plural strings in ExprtextOf

4 participants

@CJH3139 @sovdeeth @Absolutionism @TheMug06