Skip to content

Add aliases for closest to nearest entity expression #8226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev/patch
Choose a base branch
from
Open

Add aliases for closest to nearest entity expression #8226

wants to merge 3 commits into from

Conversation

CJH3139
Copy link
Contributor

@CJH3139 CJH3139 commented Oct 5, 2025

Problem

#8223

Solution

"[the] nearest %%..." -> "[the] (nearest|closest)" ...

Testing Completed

Made a short testing section in ExprNearestEntity.sk (Lines 21-24) but commented it as the top of the file stated # server doesn't spawn the entities until the next tick, and we can't wait in the test system so... commented for now

Supporting Information

Completes: #8223
Related: none

@CJH3139 CJH3139 requested a review from a team as a code owner October 5, 2025 23:48
@CJH3139 CJH3139 requested review from Pesekjak and TheMug06 and removed request for a team October 5, 2025 23:48
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Oct 5, 2025
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 5, 2025
@sovdeeth sovdeeth linked an issue Oct 5, 2025 that may be closed by this pull request
Add aliases for closest to nearest entity expression #8223
Open
1 task
sovdeeth
sovdeeth requested changes Oct 5, 2025
View reviewed changes
@sovdeeth sovdeeth added the don't merge me !! For pull requests that should not be merged due to some outstanding dispute, conflict or dependency. label Oct 6, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Merge in 2.13 Releases Oct 6, 2025
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Oct 6, 2025
@sovdeeth sovdeeth removed the don't merge me !! For pull requests that should not be merged due to some outstanding dispute, conflict or dependency. label Oct 15, 2025
@APickledWalrus APickledWalrus moved this to Awaiting Merge in 2.14 Releases Oct 15, 2025
@sovdeeth sovdeeth changed the base branch from dev/feature to dev/patch October 16, 2025 20:28
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@Pesekjak Pesekjak Awaiting requested review from Pesekjak Pesekjak is a code owner automatically assigned from SkriptLang/core-developers

@TheMug06 TheMug06 Awaiting requested review from TheMug06 TheMug06 is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

2.14 Releases
Status: Awaiting Merge

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add aliases for closest to nearest entity expression

4 participants

@CJH3139 @sovdeeth @Efnilite @Absolutionism