-
Notifications
You must be signed in to change notification settings - Fork 10
Add mt-router api #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add mt-router api #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new smartling-mt-router-api
module that provides a v2 MT Router API client, its DTOs, factory, and accompanying tests.
- Adds
MtRouterApi
interface andMtRouterApiFactory
for calling thegenerateAccountTranslations
endpoint. - Defines request/response DTOs (
TranslationPTO
,ErrorPTO
,SourceStringCommandPTO
,GenerateAccountTranslationCommandPTO
). - Includes sample JSON responses and unit tests covering success and error scenarios.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
smartling-mt-router-api/src/test/java/com/smartling/api/mtrouter/v2/SampleApiResponses.java | Sample JSON templates for success and error API responses |
smartling-mt-router-api/src/test/java/com/smartling/api/mtrouter/v2/MtRouterApiTest.java | Unit tests for generateAccountTranslations (success & error) |
smartling-mt-router-api/src/main/resources/com/smartling/api/mtrouter/v2/sdk-project.properties | Defines artifactId and version for the new module |
smartling-mt-router-api/src/main/java/com/smartling/api/mtrouter/v2/pto/TranslationPTO.java | DTO for translation response |
smartling-mt-router-api/src/main/java/com/smartling/api/mtrouter/v2/pto/ErrorPTO.java | DTO for error details |
smartling-mt-router-api/src/main/java/com/smartling/api/mtrouter/v2/pto/SourceStringCommandPTO.java | DTO for individual source strings |
smartling-mt-router-api/src/main/java/com/smartling/api/mtrouter/v2/pto/GenerateAccountTranslationCommandPTO.java | DTO for bulk translation request |
smartling-mt-router-api/src/main/java/com/smartling/api/mtrouter/v2/MtRouterApiFactory.java | Factory for building the MT Router API client |
smartling-mt-router-api/src/main/java/com/smartling/api/mtrouter/v2/MtRouterApi.java | JAX-RS interface defining the /accounts/{accountUid}/smartling-mt endpoint |
smartling-mt-router-api/src/main/pom.xml | Maven POM for smartling-mt-router-api module |
pom.xml | Adds smartling-mt-router-api to the parent project modules |
smartling-mt-router-api/src/test/java/com/smartling/api/mtrouter/v2/SampleApiResponses.java
Outdated
Show resolved
Hide resolved
...ng-mt-router-api/src/main/java/com/smartling/api/mtrouter/v2/pto/SourceStringCommandPTO.java
Outdated
Show resolved
Hide resolved
rsukharnyk-smartling
approved these changes
May 15, 2025
spivenko
approved these changes
May 15, 2025
andreyfurdylo
approved these changes
May 15, 2025
…er/v2/SampleApiResponses.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…er/v2/pto/SourceStringCommandPTO.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AlexArcher
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mt-router api
JIRA Ticket