fix: fix sdk-project.properties project variables substitution #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-radchenko
requested review from
AlexArcher,
AlexanderNovak,
PavloMyrotiuk,
andreyfurdylo,
bloy-smartling,
dimitrystd,
dsavchenko-sm,
klegins-smartling,
pshander,
sl-mmuradov,
vbarhatov and
vfisyuk-smartling
as code owners
sl-mmuradov
approved these changes
Jun 10, 2025
dimitrystd
approved these changes
Jun 10, 2025
vbarhatov
approved these changes
Jun 12, 2025
pshander
approved these changes
Jun 12, 2025
andreyfurdylo
approved these changes
Jun 12, 2025
AlexanderNovak
approved these changes
Jun 12, 2025
AlexArcher
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated sdk-project.properties, which is included within sdk jar, for many sdks contains unextended project variables.
When one uses sdk, by default properties taken from sdk-project.properties are used to generate User-agent header which leads to user-agent header looking like this in our apigateway log:
2025-06-10 11:15:47:682 +0000 - [INFO] [http-nio-8443-exec-431] (RequestSummaryFilter.java:run:159) rid=002a673a-966e-4ec6-a0de-442b8c7e52fa#tqdm [MAINLOG] Request finished, status_code=200, service_id=JOBS-SERVICE, total_time=36, auth_filter_time=29, user=service+email-notifications@smartling.com, method=POST, url="https://api.smartling.com/jobs-admin-api/v3/projects/f67df5d74/find-jobs-by-content", service_uri="/jobs-admin-api/v3/projects/f67df5d74/find-jobs-by-content", auth_source=header, user_agent="${project.artifactId}-java/${project.version}", exception_happened=false, service_origin="email-notifications-service", projectId=f67df5d74The way to fix it is substitute project.artifactId and project.version variables in sdk-project.properties when this file is copied into the jar file during build process. So in the end we would have correct sdk-project.properties file inside sdk's jar:
To do this we need to use filtering when we copy resources into jar.
https://smartling.atlassian.net/browse/TCM-5747