Skip to content

Conversation

@svij-sc
Copy link
Collaborator

@svij-sc svij-sc commented Nov 25, 2025

Scope of work done

If g4 machines are specified, pd-ssd are not supported.
We need to default to hyperdisk-balanced

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: YES

@svij-sc
Copy link
Collaborator Author

svij-sc commented Nov 25, 2025

/help

@github-actions
Copy link
Contributor

GiGL Automation

@ 01:17:57UTC :

🤖 Available PR Commands

You can trigger the following workflows by commenting on this PR:

  • /help - Checkout code
  • /unit_test_py - Run Python Unit Tests
  • /unit_test_scala - Run Scala Unit Tests
  • /integration_test - Run Integration Tests
  • /e2e_test - Run E2E Tests
  • /notebook_tests - Run Example Notebooks Tests
  • /lint_test - Run Linting Tests

💡 Usage: Simply comment on this PR with any of the commands above (e.g., /unit_test)

⏱️ Note: Commands may take some time to complete. Progress updates will be posted as comments.

@svij-sc
Copy link
Collaborator Author

svij-sc commented Nov 25, 2025

/lint_test

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

GiGL Automation

@ 01:18:24UTC : 🔄 Lint Test started.

@ 01:25:59UTC : ❌ Workflow failed.
Please check the logs for more details.

@svij-sc svij-sc changed the title g4 default hyper disk On g4 default to hyper disk Nov 25, 2025
Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this too complicated? I don't think we should swap things out for users like this. It's not hard to retry the existing run with a new disk config.

If the issue is that we don't expose boot_disk_type to users at all, then why not do that via the VertexAIResourceConfig?

I'd rather this all be explicit and we require users to set the boot disk. I feel like going down the path of doing things for users will overcomplicate our code and have us chasing down GCP requirements

@kmontemayor2-sc
Copy link
Collaborator

Synced offline - I think it's fine to auto-infer this since we never expose disk to user and they don't use disk anyways.

But let's add this to build_job_config added in #390?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants