Add default notification email to kfp pipeline #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
yliu2-sc
approved these changes
Dec 2, 2025
svij-sc
requested changes
Dec 5, 2025
Collaborator
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
discussed alternatives offline
svij-sc
reviewed
Dec 18, 2025
| stop_after: Optional[str] = None, | ||
| notification_emails: Optional[List[str]] = None, | ||
| # We need to provide *some* notification emails, other wise the cleanup component will fail. | ||
| notification_emails: List[str] = [get_resource_config().service_account_email], |
Collaborator
There was a problem hiding this comment.
does this also fix make compile_gigl_kubeflow_pipeline ?
Collaborator
Author
There was a problem hiding this comment.
that issue is due to no pipeline path being provided, it's separate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
Add default notification email to kfp pipeline
Do this so we can compile the pipeline without needing some "default" email.
As discussed offline we need to do it this way - there doesn't seem to be a way to get the KFP DSL to play nicely with this.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO