[Update Deps] Documentation Release Update #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svij-sc
had a problem deploying
to
github-pages
GitHub Actions
Failure
svij-sc
had a problem deploying
to
github-pages
GitHub Actions
Failure
svij-sc
had a problem deploying
to
github-pages
GitHub Actions
Failure
svij-sc
had a problem deploying
to
github-pages
GitHub Actions
Failure
svij-sc
had a problem deploying
to
github-pages
GitHub Actions
Failure
svij-sc
changed the title
svij-sc
commented
Dec 13, 2025
| "pre-commit==3.3.2", | ||
| ] | ||
| docs = [ | ||
| "astroid==3.3.11", # Newer versions of astroid are not compatible with sphinx==7.4.7 |
Collaborator
Author
There was a problem hiding this comment.
need to lock this as newer versions seem incompatible with the sphinx autodoc version.
10 tasks
Collaborator
There was a problem hiding this comment.
This removal is unrelated to this PR right?
Again, I really prefer to avoid these unrelated changes if possible.
Collaborator
Author
There was a problem hiding this comment.
Its releated as it was causing issues with build - i dunno why.
yliu2-sc
approved these changes
Dec 15, 2025
kmontemayor2-sc
approved these changes
Dec 16, 2025
| # that dependencies can be resolved. | ||
| - name: Setup Machine for releasing documentation | ||
| uses: snapchat/gigl/.github/actions/setup-python-tools@main | ||
| uses: ./.github/actions/setup-python-tools |
Collaborator
There was a problem hiding this comment.
should we revert this?
Collaborator
Author
There was a problem hiding this comment.
I will do this post PR merge along with the other similar changes.
Post PR merge we will need to update back ./.github/actions/setup-python-tools --> snapchat/gigl/.github/actions/setup-python-tools@main
svij-sc
requested review from
mkolodner-sc,
nshah-sc,
xgao4-sc and
zfan3-sc
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following, #414
We need to update the release documentation workflow so it continues to work.
As well, needed to freeze
astroid, as newer versions don't seem to be compatible with sphinx causing compile time failures like:Unable to read file: .... .py