Skip to content

Conversation

@busybox11
Copy link

Since devs will need to setup some parts of the Android SDK themselves beforehand, as instructed in the MacOS and Linux setup guide, this PR adds a notice to install the latest Android SDK CLI Tools from the SDK Manager as well.

This PR also removes the manual download, unzip, copy and handling of the sdkmanager, but rather assumes the user has followed the setup guide and installed the tools from SDK Manager.

Fixes #1

@busybox11
Copy link
Author

busybox11 commented Nov 8, 2025

This assumes manual Android Studio setup is required.

In theory only the sdkmanager would be required to complete the installation, and manual selection of specific NDKs and tool versions is already handled by DevSetupHelper::setupAndroidSDK().

Those could be removed from the guide, lmk if I should add this as well - or if the manual Android Studio part should be removed instead, which could be a little more flaky. Went for the simplest option for now.


Install ndk version **25.2.9519653**

Install the latest version of **Android SDK Command-line Tools**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it!

@ecoreng ecoreng mentioned this pull request Nov 19, 2025
@ecoreng
Copy link

ecoreng commented Nov 19, 2025

👍🏼

@sushilvisual
Copy link

Thanks for this cleanup — it’s a useful simplification and I appreciate moving away from brittle downloads. Before we can approve, please address the following changes:

  1. Windows support: add a Windows-aware check/fallback for the Android SDK command-line tools. For example, verify sdkmanager.bat in %ANDROID_HOME%\\cmdline-tools\\latest\\bin or fall back to searching PATH for sdkmanager(.bat) so Windows developers aren’t blocked.

  2. Improve the missing sdkmanager error message: make it actionable. Include a short install instruction and a link, for example:

  3. (Optional but recommended) Add a small CI check or unit test (if possible) to catch regressions related to removed constants and the setupAndroidSDK path.

After these are addressed I’ll re-review. Thanks for the contribution — nice work so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue running setup CLI

4 participants