Fix failing tests due to scikit-learn versions #4253
Merged
+36
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
added
curation
alejoe91
reviewed
Dec 10, 2025
…ow/spikeinterface into fix-scikitlearn-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some failing tests: https://github.com/SpikeInterface/spikeinterface/actions/runs/20093848765/job/57647307083?pr=4190
In our automated curation tests, we previously had a stored model. This was generated using scikit-learn v1.3.2. this is now incompatible with scikit-learn v1.9.
There's a bigger problem here: how do we ensure models are usable in the future (one possible answer: by default we store everything used to train them, so you can retrain using a newer sklearn verison).
More practically, so that this doesn't happen again: I've replaced the fixed created model with one that is created during ci (=> using the scikit-learn verison of the environment). You should only have to do this once per test suite run.