-
Notifications
You must be signed in to change notification settings - Fork 99
chore(colors): tweak colors to match latest values for SHINE #2094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8c542e2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CGuindon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Light HC mode looks correct.
Dark HC needs a change for:
yellow-300#E5D17E (it's different than regular Dark)green-300#C4E589 (very minor tweak)green-400#CCE5A1 (very minor tweak)orange-300#DFAD90orange-400#fcccb1blue-300#A6C4FF
Update: https://stackexchange.slack.com/archives/C096063B1PH/p1765209444766689 |
This reverts commit f99f8fa.
dancormier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot checked a color from each set and they all matched up to the variables in figma. Thanks @mukunku!
Summary
Some colors needed tweaking so this PR updates our colors to the latest values defined in the Figma designs.
How to Test
No easy way to test this change besides spot checking a few colors and comparing them to what we have in code vs. what's in the Figma designs.
Here are the latest colors from color-sets.less in table form for easy viewing: https://docs.google.com/spreadsheets/d/1bemMtdwnJKRs0uIM9dfT5507r-cXxQKtE5MEC_vGd_U/edit?gid=0#gid=0