Skip to content

Conversation

@mukunku
Copy link
Collaborator

@mukunku mukunku commented Dec 5, 2025

Summary

Some colors needed tweaking so this PR updates our colors to the latest values defined in the Figma designs.

How to Test

No easy way to test this change besides spot checking a few colors and comparing them to what we have in code vs. what's in the Figma designs.

Here are the latest colors from color-sets.less in table form for easy viewing: https://docs.google.com/spreadsheets/d/1bemMtdwnJKRs0uIM9dfT5507r-cXxQKtE5MEC_vGd_U/edit?gid=0#gid=0

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

🦋 Changeset detected

Latest commit: 8c542e2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 8c542e2
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/69373125880445000843bb57
😎 Deploy Preview https://deploy-preview-2094--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 8c542e2
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/69373125c91fe30008086d8a
😎 Deploy Preview https://deploy-preview-2094--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mukunku mukunku marked this pull request as ready for review December 5, 2025 21:08
Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light HC mode looks correct.

Dark HC needs a change for:

  • yellow-300 #E5D17E (it's different than regular Dark)
  • green-300 #C4E589 (very minor tweak)
  • green-400 #CCE5A1 (very minor tweak)
  • orange-300 #DFAD90
  • orange-400 #fcccb1
  • blue-300 #A6C4FF

@mukunku
Copy link
Collaborator Author

mukunku commented Dec 8, 2025

  • A6C4FF

Looks like Figma is rounding the HSV/HSBA values which is causing the discrepancy. By converting your Hex values to HSV/HSBA myself I was able to accurate represent the colors as you mentioned: f99f8fa

Update: https://stackexchange.slack.com/archives/C096063B1PH/p1765209444766689
We decided to not use fractionals so we're keeping the values as they were.

This reverts commit f99f8fa.
@mukunku mukunku requested a review from CGuindon December 8, 2025 19:25
Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked a color from each set and they all matched up to the variables in figma. Thanks @mukunku!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants