Skip to content

Conversation

@SteveLin100132
Copy link
Owner

Fixes: #23

This pull request primarily refactors the SettingsPanel component in frontend/src/components/settings-panel.tsx to use consistent double-quote style and improve code readability, while also enhancing the robustness and clarity of the chart generation and filter handling logic. There are no functional changes to business logic, but the code is now more maintainable and easier to follow. Additionally, the CHANGELOG.md is updated to document a recent bug fix for multi-select filtering.

Changelog update:

  • Added a detailed entry for version 1.1.7, documenting the fix for multi-select field filtering errors when generating charts, including root cause, solution, and affected files.

Code style and readability improvements:

Chart generation and filter handling improvements:

  • Improved error handling and logging in chart generation, including clearer console outputs and more robust error messages. [1] [2]
  • Enhanced the logic for handling filter groups and converting them to Notion API filters, with additional debug logs for troubleshooting. [1] [2]
  • Updated UI components to improve user feedback, such as dynamically disabling/enabling controls based on available properties and filter states. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

These changes should make the codebase easier to maintain and help prevent similar issues with filter handling in the future.

@SteveLin100132 SteveLin100132 self-assigned this Aug 10, 2025
@SteveLin100132 SteveLin100132 added bug Something isn't working build Build docker image labels Aug 10, 2025
@SteveLin100132 SteveLin100132 merged commit 2de35e6 into master Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build Build docker image

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[進階篩選設定] 選擇 Notion multi_select 欄位無法生成圖表且出現錯誤提示

2 participants