chore(k8s): update commonName and dnsNames in certificate and ingress configurations for clarity #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configurations for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the domain configuration for the Notion Chart Generator service in the Kubernetes manifests. The changes ensure that the service uses the more specific subdomain
notion-chart-generator.188-166-204-94.nip.ioinstead of the previous generic domain.Domain configuration updates:
commonNameanddnsNamesfields ink8s/certificate.yamlto usenotion-chart-generator.188-166-204-94.nip.iofor certificate issuance.hostsandrulesfields ink8s/ingress.yamlto route traffic fornotion-chart-generator.188-166-204-94.nip.ioand use the corresponding TLS secret.