Correction to FDIR Conversion Table #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 24, 2025 10:28
correct FDIR.factors.VIII.2022 product type 3 = GWOH, 4 = GWH See merge request digital-utvikling/r-packages/stoxproject/RstoxFDA!1
add makefile See merge request digital-utvikling/r-packages/stoxproject/RstoxFDA!2
Merge correct test See merge request digital-utvikling/r-packages/stoxproject/RstoxFDA!3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of the package, the author mistakenly classified ProductType 3 as GWH and 4 as GWOH whereas the handbook shows the opposite.
All GWH conversion factors should be less than GWOH (ConversionFactor[ProductType == 4] < ConversionFactor[ProductType == 3].
Changes here include: