Allow a way to set filterName and filterPattern when creating a Subscription filter #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmavromichalis
commented
Sep 22, 2025
Comment on lines
+202
to
+203
| var filterName = env.FILTER_NAME | ||
| var filterPattern = env.FILTER_PATTERN |
There was a problem hiding this comment.
I'm not sure if these should also be validated with validateRegex or validated a different way?
Comment on lines
+115
to
+116
| var filterName = process.env.FILTER_NAME | ||
| var filterPattern = process.env.FILTER_PATTERN |
There was a problem hiding this comment.
I'm not sure if these should also be validated with validateRegex or validated a different way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #165
It looks like
filterNameandfilterPatternare stubbed out to beSumoLGLBDFilterand an empty string respectively in the functioncreateSubscriptionFilterinloggroup-lambda-connector/src/loggroup-lambda-connector.js.I think this was done because PutSubscriptionFilter requires these arguments.
I would like a way to set
filterNameandfilterPatternto something other than what is hard coded here. I think we can do this the same wayLOG_GROUP_PATTERNorLOG_GROUP_TAGSis provided.My changes are an attempt to move the hard coded values into parameters so they can be overridden if desired.
I would appreciate help and guidance with this.