Fix security vulnerabilities #425
Conversation
- Migrate from `swagger-parser` to successor `@apidevtools/swagger-parser` - Bump dev packages with security vulnerabilities - Fix cleanup issue with test when files do not exist
|
Thank you for this PR. I would like to see this PR merged. However, it appears that this project is no longer active. |
|
@martin-badin could you please merge this PR in our project we are blocked and it's impacting our production also |
|
Sorry. I am not owner. |
|
@daniloab Do you be able to review and merge this PR? |
Hey, I'm going to review. Sorry for the late. |
| tryUnlink(`${dir}/swagger.json`); | ||
| tryUnlink(`${dir}/customSpec.json`); | ||
| tryUnlink(`${dir}/customSpec.yaml`); | ||
| tryUnlink(`${dir}/customSpec.yml`); |
There was a problem hiding this comment.
Can also just skip removing this non existent file (instead of wrapping in try/catch)
There was a problem hiding this comment.
Is this failing or the try catch is working as expected?
There was a problem hiding this comment.
Try catch is working as expected. But the .yml file doesn't exist - so we can alternatively just remove line 152 (like I do in my other PR).
6 participants
swagger-parserto successor@apidevtools/swagger-parser