Fix autoheal for virtuoso #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need further changes to add autodial to frontend and backend
completes last commit
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the external autoheal container with built-in healthchecks on the Virtuoso service, restructures how Virtuoso is built, and ensures SynBioHub waits for Virtuoso to be healthy.
- Remove
autohealservice and labels; introduce a custom Virtuoso image viaDockerfile.virtuoso - Add a healthcheck to the Virtuoso service and use
depends_onwith health conditions for SynBioHub - Reorder and slim down the frontend service definition
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker-compose.yml | Removed autoheal and legacy labels; switched Virtuoso to build context, added healthcheck and long-form depends_on; moved frontend config |
| Dockerfile.virtuoso | New Dockerfile based on the official Virtuoso image, installing curl for healthchecks |
Comments suppressed due to low confidence (2)
docker-compose.yml:1
- The top-level
versionkey was removed; without specifyingversion: '3.4'(or higher), the healthcheck and long-formdepends_onsyntax may not be recognized by Docker Compose. Please re-add aversionfield to ensure compatibility.
services:
docker-compose.yml:38
- The
synbiohubFrontendservice no longer includes thebackendandbackendSSenvironment variables; without them, the UI may fail to locate the backend endpoints. Reintroduce or update these variables as needed.
synbiohubFrontend:
no install recommends Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Let's discuss this during next week's hackathon. Please be sure to remind me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.