Fix a situation where copy/paste hotkeys don't work.

[SuuperW]

I sometimes find that I am unable to copy/paste inputs in TAStudio. Maybe this fixes it. It does fix this particular situation:

1. Click the marker list or another control to ensure it has focus
2. Do not move the mouse over the input list
3. Alt+tab to another window
4. Alt+tab back
5. Try to copy with Ctrl+C.

This might not fix it in every case. There have been several times when I am unable to copy/paste with the keyboard even after clicking the input list, moving the mouse around, clicking another window then going back to TAStudio... nothing seems to work. I have no idea how to reproduce that, but I do know by using the debugger that when it happens pressing Ctrl+C does not enter CopyMenuItem_Click. That issue has been fixed.

Check if completed:

• I have run any relevant test suites
• I, the commit author, have read the licensing terms for contributors (last updated 2024-06-22) and am compliant

[Morilli]

No idea what steps 3 and 4 are for, they are not required. With that in mind this isn't a "fix", just a behavior change that allows hotkeys for the input roll to work everywhere in the tastudio window, not just when the input roll is focused.

Considering mono does not handle focus correctly (#4375) and I don't see a situation in which not focusing the input roll should do anything meaningful I think the best course of action here is not to try and select the TasView on any random user action but rather allow it to not be selected and still handle the corresponding hotkeys.

There's already a random TasView.Select() on TasView_MouseEnter (the whole reason your step 2 is even necessary), let's not add another. It seems like the best solution is to remove all explicit Select() calls and all .Focused checks.

[SuuperW]

I think the best course of action here is not to try and select the TasView on any random user action but rather allow it to not be selected and still handle the corresponding hotkeys. It seems like the best solution is to remove all explicit Select() calls and all .Focused checks.

I think that would be good. Probably the way to make copy/paste work would be making them BizHawk hotkeys (instead of relying on the tool strip menu item to handle it via shortcut keys). Like everything else is.

[SuuperW]

Removed the focus checks.

The seemingly random TasView.Focus() is left. Commit 4d97d06 says it's about RMB+wheel scroll. It's still a bad solution but simply removing it will cause issues.

[YoshiRulz]

Yes, "Clone # Times" works on my machine with this patch.

[YoshiRulz]

This changes the semantics—but I think it was a typo before and should have read !TasView.Focused || !TasView.AnyRowsSelected like elsewhere in this file, so it would now work as intended.

[YoshiRulz]

ditto

[Morilli]

The seemingly random TasView.Focus() is left. [...] simply removing it will cause issues.

Have you tested this? I tested briefly with it removed and didn't notice any difference in behavior.

[SuuperW]

Yes, RMB+wheel scroll doesn't work if you click outside the TasView, until it is re-focused.