Skip to content

Don't show tags that can cause cyclical dependency. Fixes #1074 #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HEROgold wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Don't show tags that can cause cyclical dependency. Fixes #1074 #1258

HEROgold wants to merge 6 commits into from
+73 −23

Conversation

@HEROgold
Copy link

@HEROgold HEROgold commented Dec 12, 2025 •
edited
Loading

Summary

Fix for #1074
I've updated the fix made in #1075 to track already visited tags.
I've added helper methods to get tag children/descendants
Creating cyclical parent's is no longer possible, by checking all tag's descendants.

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@HEROgold
ignore development files
14acfef
@HEROgold
fix ignores
bf47715
@HEROgold
Separate configs to their dedicated files
ff42324
@HEROgold
Properly fix TagStudioDev#1075
58c7cc4
@HEROgold
Don't show tags that can cause cyclical dependency. Fixes TagStudioDe…
1d0e021 
…v#1074

Use set to avoid duplicate values.
Also include all tag descendants in the exclusion, this avoids showing already parented tags.
Bandaid fix for type error on TagSearchModal: converting to a list

Ideally TagSearchModel can take any Iterable (future fix)
@HEROgold
Revert "Separate configs to their dedicated files"
8ecadb0 
This reverts commit ff42324.
@CyanVoxel CyanVoxel added TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system labels Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HEROgold @CyanVoxel