-
-
Notifications
You must be signed in to change notification settings - Fork 83
feat: add oxlint support #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…-app into add-oxlint-support
|
Added @prettier/plugin-oxc as recommended by oxc (https://oxc.rs/docs/guide/usage/formatter.html) and merged latest main version |
|
Any feedback @jherr? |
Yeah, my issue is with the .oxlintrc.json (which should be _dot_oxlintrc.json but that's not the issue). Does it need to be that large? Is there some widely used default for it? |
Hey @jherr! Thanks for taking a look at this. Regarding the On the filename: You're absolutely right about the naming convention. My bad. I'll fix that. On the file size: The current config is indeed what The generated config is comprehensive because it explicitly lists all available plugins and rules with their default settings. For a project template, we have a few options:
{
"plugins": ["react", "unicorn", "typescript", "oxc"],
"categories": {
"correctness": "error"
}
}
To reduce file size I would personally lean toward option 1 (minimal config) since it:
What do you think? I'm happy to slim it down to a minimal config that just enables the plugins and maybe a few project-specific overrides if needed or delete the file entirely. |
|
Cool. Hearing that it's the |
Closes #166
Added oxlint as a linter option :)