-
-
Notifications
You must be signed in to change notification settings - Fork 508
Add alternative validation methods #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit fcb613e
☁️ Nx Cloud last updated this comment at |
dfbaaae
to
da3df18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it a lot! Just some minor things that should be cleared up, but it's looking promising!
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
+ Coverage 90.38% 90.51% +0.12%
==========================================
Files 36 37 +1
Lines 1623 1686 +63
Branches 386 421 +35
==========================================
+ Hits 1467 1526 +59
- Misses 139 143 +4
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds in a new (optional) property called
validationLogic
that allows us to emulate alternative validation methods, like the one from RHF where validation does not occur until the first submission, then it validates on change:This is a draft pull request and will not be landing immediately, as it is a substantial internal refactor of our code. Once code is done, we'll need docs for all frameworks
TODO
reValidateMode
andmode