Fix: display correct NPM download count for TanStack Config #496
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the getStats function to return a default package format when no frameworks are provided in the library argument. This ensures compatibility for libraries like @tanstack/config.
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 912b67a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Display correct NPM download count for TanStack Config
Previously, the NPM download count for TanStack Config was showing as NaN. This was due to the
frameworksarray being empty insrc/libraries/config.tsx. ThegetNpmPackagesfunction inconvex/stats.tswas attempting to construct package names using a framework prefix (e.g.,@tanstack/{framework}-config), which resulted in an empty list of package names whenframeworkswas empty.This fix modifies the
getNpmPackageslogic to handle libraries like TanStack Config, which do not have framework-prefixed package names. If a library'sframeworksarray is empty, it now correctly uses@tanstack/{library.id}as the package name for fetching NPM download statistics.