feat: add support for Angular 20 #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 72dfd29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jsaguet
force-pushed
the
feat/drop-angular-17-support
branch
from
71f1fda to
8193130
Compare
|
View your CI Pipeline Execution ↗ for commit 72dfd29
☁️ Nx Cloud last updated this comment at |
This commit switches to the new afterNextRender API available since 18.1.0 to remove usage of `AfterRenderPhase` that was removed in Angular 20. The minimal required Angular version is now 18.1.0
jsaguet
force-pushed
the
feat/drop-angular-17-support
branch
from
cc24c39 to
72dfd29
Compare
Merged
|
@jsaguet Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This PR adds support for Angular 20.
AfterRenderPhasewas removed in Angular 20 so I've updated the code to switch to the newafterNextRenderAPI available since 18.1.0 instead.The minimal required Angular version is now 18.1.0
Note:
Angular 18.1 requires Typescript 5.4 so I've updated the typescript version to 5.4 in every package devDependencies for consistency.
Closes #1034
✅ Checklist
This is technically a breaking change but I'm guessing bumping only one package is not what's expected here.
Let me know and I'll adjust the changeset.