refactor build configuration (production & test) #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dhebbeker
commented
Sep 21, 2024
dhebbeker
commented
- resolves restructure build environments? #108
- resolves restructure test environments? #83
- Merge common parts. - Do not use separate configurations for each test.
This ensures that the baud rate is the same as the one configuring the serial monitor.
This was why I had to apply 6d261d6. The lead to confusion with the CI. Being more specific is better.
dhebbeker
force-pushed
the
feature/83-restructure-test-environments
branch
from
925ff66 to
68f5679
Compare
dhebbeker
commented
Sep 21, 2024
There was a problem hiding this comment.
The biggest change is that the build environments for testing have been merged. They were not very distinct in the first place. As ldf_mode=chain is used, mocking should still work as expected.
Comments were removed which were not specific for the configuration but were explaining how to use PlatformIO instead. PlatformIO documentation should not be copied into the ini-file. What should be added as comment is the intention why a setting has been defined in a certain way.
dhebbeker
force-pushed
the
feature/83-restructure-test-environments
branch
from
87dfe1a to
9f4bb13
Compare
dhebbeker
added
CI infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.