-
Notifications
You must be signed in to change notification settings - Fork 0
[TB-28] 영수증 월별 지출액 조회 API 구현 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a monthly expense retrieval API for receipts by introducing a new domain model (DetailExpenseResult) and corresponding service, DTO, and API endpoint changes.
- Adds a new method in ReceiptEditor to calculate monthly expenses.
- Introduces DetailExpenseResult and ReceiptExpenseResponse to encapsulate monthly expense data.
- Updates service, use case, and controller layers to support the new API endpoint.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ReceiptEditor.java | Adds calculateExpense with monthly grouping of receipts. |
| DetailExpenseResult.java | Introduces the domain model for representing monthly expense results. |
| FindReceiptService.java | Implements the service method mapping expense data to response DTOs. |
| FindReceiptUseCase.java | Extends the use case interface with expense list retrieval. |
| ReceiptExpenseResponse.java | Creates a new DTO for monthly expense data with a builder-based factory method. |
| FindReceiptApi.java | Defines the API endpoint for querying monthly expense data. |
| FindReceiptController.java | Exposes a new GET endpoint to retrieve monthly expense information. |
Comments suppressed due to low confidence (1)
src/main/java/com/ClubAccount_BE/receipt/domain/service/ReceiptEditor.java:54
- [nitpick] Consider renaming 'calculateExpense' to 'calculateMonthlyExpense' to better reflect the operation performed.
public List<DetailExpenseResult> calculateExpense(List<Receipt> receiptList, int year) {
...main/java/com/ClubAccount_BE/receipt/adapter/in/web/dto/response/ReceiptExpenseResponse.java
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후에 말씀해주신대로 usecase분리 해주시면 될거 같습니다!
고생하셨습니다
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |



📌 작업 개요
✅ 작업 내용
DetailExpenseResult반환📂 리뷰 요구사항