- 
                Notifications
    You must be signed in to change notification settings 
- Fork 75
FEATURE: ReportSys test for SLES pallet patch #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
        
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
          
            Show resolved
            Hide resolved
        
      8d88199    to
    76c8041      
    Compare
  
            
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      9d66b6e    to
    6c8fea4      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the recommended code changes and re-examine the code logic. I'm not sure this is actually testing that all the files in all the RPMs have the correct hashes.
        
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | assert sles_flavors | ||
|  | ||
| # Find out where is stack-sles*images*.rpm file(s) | ||
| result = host.run('find /export/stack/pallets/stacki/ -name "*stack-sles-*.rpm"') | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern should have a \ before the .:
"*stack-sles-*\.rpm"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having \ before . broke the code.
        
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
          
            Show resolved
            Hide resolved
        
              
          
                common/src/stack/report-system/command/report/system/tests/test_sles_patch.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | Updated output Failure case  | 
Output