Skip to content

Conversation

jk1ng
Copy link

@jk1ng jk1ng commented Jun 7, 2025

Support for parsing the public_url parameter for the path prefix is now in-place.

@jk1ng
Copy link
Author

jk1ng commented Jun 7, 2025

Whoops, I didn't realize this was going to do a PR against the upstream repository; rookie mistake.

Feel encouraged to close this with prejudice - alternatively, happy to work with your team to adjust this code to be suitable for merging.

One problem with this kind of PR is that the front end JavaScript is minified so it's not trivial to see what changed. The only things I should have changed there were: 1) adding support for reading the new path prefix HTML Element dataset property (added to src/textual_serve/templates/app_index.html) by adding this.pathPrefix=e.dataset.pathPrefix; to the w constructor, and 2) adding support for using that value later in ${window.location.origin}/${this.pathPrefix}download/${i}${r} (the URL the browser is directed to open when downloading a file).

jk1ng and others added 2 commits June 6, 2025 23:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant