Skip to content

Conversation

TomJGooding
Copy link
Collaborator

@TomJGooding TomJGooding commented Sep 16, 2025

Python 3.14 should be released in just a few weeks, which means Python 3.8 has been end-of-life for almost a year.

This drops support for Python 3.8 and adds testing in CI for Python 3.14.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@TomJGooding
Copy link
Collaborator Author

Tests failed with Python 3.9 with RuntimeError: There is no current event loop in thread 'MainThread'.

I've not dived into this yet, but earlier versions of pytest-asyncio might have been hiding some test issues: pytest-dev/pytest-asyncio#1039

After upgrading `pytest-asyncio` to the latest version, lots of tests
started failing in CI only on Python 3.9:

`RuntimeError: There is no current event loop in thread 'MainThread'`

Apparently these tests may have only been passing previously due to
issues in earlier versions of `pytest-asyncio`. Changing these tests to
async seems to fix the failures on Python 3.9.

Related issue:
pytest-dev/pytest-asyncio#1039
@TomJGooding
Copy link
Collaborator Author

Unfortunately I've discovered that the Textual devtools currently doesn't support Python 3.14:

@willmcgugan
Copy link
Member

Hi @TomJGooding Curious why you made the test async. What was that solving?

@TomJGooding
Copy link
Collaborator Author

Curious why you made the test async. What was that solving?

See comments in 7a9d32f

@willmcgugan willmcgugan mentioned this pull request Oct 11, 2025
@willmcgugan willmcgugan marked this pull request as ready for review October 11, 2025 11:16
@willmcgugan
Copy link
Member

Thanks, Tom.

@willmcgugan willmcgugan merged commit eed9aa0 into Textualize:main Oct 11, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants