Skip to content

test(modal): add sanity check for flaky test in CI #6142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test(modal): add sanity check for flaky test in CI #6142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c7738c
test(modal): add sanity check for flaky test in CI
TomJGooding Sep 29, 2025
80dc94f
test(modal): try reducing the pause in flaky test
TomJGooding Sep 29, 2025
3186ae6
test(modal): increase pause again in flaky test
TomJGooding Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_modal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ async def test_modal_pop_screen():
app = ModalApp()
async with app.run_test() as pilot:
# Pause to ensure the footer is fully composed to avoid flakiness in CI
await pilot.pause()
await pilot.pause(0.4)
await app.wait_for_refresh()
await pilot.pause()
# Check clicking the footer brings up the quit screen
await pilot.click(Footer, offset=(1, 0))
footer_key_clicked = await pilot.mouse_down("FooterKey")
assert footer_key_clicked is True # Sanity check
await pilot.pause()
assert isinstance(pilot.app.screen, QuitScreen)
# Check activating the quit button exits the app
Expand Down
Loading