-
Notifications
You must be signed in to change notification settings - Fork 2
Task/Quote form assessment #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grananda
wants to merge
26
commits into
TheCodeOne:main
Choose a base branch
from
grananda:task/assessment-task-jfern
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fba0b2 to
d69f203
Compare
…nt configuration for clear code clustering
… functionality (moment, faker)
…improved module compatibility
…yles, and tests for date input handling
…form with enhance error handling for date input
…urtsdatum in quote request and improve error handling
…e and update related tests for improved validation handling
…orce age requirement and date format
…geburtsdatum and ensure proper quote processing
… geburtsdatum in request and response handling
…ring calculation process
d69f203 to
a85b433
Compare
…ts for string generation
b109421 to
396aacf
Compare
40c200a to
9f7febc
Compare
f8f11f7 to
c5b78d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR completes the "Quote" functionality implementation for the requested assessment.
Tasks
The following tasks were completed during the development of this feature:
A date picker UI control was implemented with custom validations and back-end processing workflow.
A standard Aquila spinner was introduced to provide user feedback during backend interactions and loading periods.
A global error message box was implemented to inform users of errors other than 400 status codes. Error handling was also extended to display 400 API errors as local validation errors.
New libraries for component and signal store were introduced to present users with detailed quote information after it was processed by the corresponding backend API endpoint.
The existing quote form component was refactored to simplify HTML and leverage Angular reactive forms and signal stores. Additional libraries were implemented to enhance code readability and maintainability.
Testing Cases
Please complete the following test cases to verify all acceptance criteria have been met:
Birthday field implementation
[01-01] Select birthdate
[01-02] Enter correct birthdate (18+ years in the past)
[01-03] Enter incorrect birthdate (less than 18 years old)
[01-04] Enter invalid date format
[01-05] Omitting birthday field
[01-06] Submit valid birthdate
Loading State Feedback
[02-01] Loading spinner displays
Error Handling
[03-01] Server-side non-400 error messages
postendpoint in thebackend/apps/bff/src/quote/controllers/quoteController.tscontroller file as follows:[03-02] Server-side 400 error messages
frontend/libs/service-lib/src/lib/service-lib/quote.service.tsas follows:Quote Summary Display
[04-01] Quote summary display